search

Azure / azure-storage-python

Microsoft Azure Storage Library for Python
https://azure-storage.readthedocs.io
MIT License
338 stars 240 forks source link

[Blob][BugFix]set_blob_service_properties Throws Exception When Param… #575

Closed xiafu-msft closed 5 years ago

xiafu-msft commented 5 years ago

…eters are All None

set_blob_service_properties should remind the users to give correct input when the users give a bad input, while now the request is still sending out even with bad parameters.

Fixes #540.

codecov-io commented 5 years ago

Codecov Report

Merging #575 into dev will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #575      +/-   ##
==========================================
+ Coverage   86.82%   86.83%   +0.01%     
==========================================
  Files          52       52              
  Lines        4819     4825       +6     
  Branches      520      521       +1     
==========================================
+ Hits         4184     4190       +6     
  Misses        467      467              
  Partials      168      168
Impacted Files Coverage Δ
...storage-blob/azure/storage/blob/baseblobservice.py 92.96% <100%> (+0.02%) :arrow_up:
azure-storage-blob/azure/storage/blob/models.py 95.96% <0%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a762a67...91b8ddb. Read the comment docs.

xiafu-msft commented 5 years ago

Fixes #540.