Closed lmazuel closed 5 years ago
So, the stacktrace lines doesn't match, but still my CI is broken right now, I'm investigating deeper.
Hi @lmazuel thanks for reaching out, I'm looking into that. I'm pretty sure blob 1.5.0 is working properly, I'm checking out 2.0.0 to test now.
So, actually the code is running 1.5.0, the CI shifted 1.5.0 and 2.0.0 last minute because of un unexpected dependency. But still, with 1.5.0 I get that message :/ Still investigating myself
@xiafu-msft @zezha-msft I found it. Looking at your release date:
But actually, 1.4.1 common and 1.5.0 are incompatible :(
Looking at your blob/setup.py, it's written "common~=1.4", this means the contract was clear that any 1.4.x common would work forever with blob 1.5.0.
IOW, all installation "pip install azure-storage-blob==1.5.0" are broken as of yesterday
I don't know the details of the changes, but I strongly suggest you make a 1.4.2 asap compatible with 1.5.0, to honor the contract committed with the setup.py of 1.5.0. That might mean your changes in 1.4.1 needs to go to a 2.0.0 of common.
Hi @lmazuel, thanks for catching this!
I made a mistake yesterday while looking at the change history, I mistakenly thought that there was no breaking change in common.
I'll fix it asap (in 1-2 hours).
@lmazuel should be fixed now. Could you please re-trigger your CI to verify?
@lmazuel looks like it's been fixed. I'll merge the hot fix branches later. Thanks a bunch! Really sorry for the inconvenience. 😭
No problem :). Indeed it works with 1.4.2. Thanks!
Which service(blob, file, queue) does this issue concern?
blob
Which version of the SDK was used? Please provide the output of
pip freeze
.2.0.0
What problem was encountered?
This code doesn't work anymore in 2.0.0:
Stack trace (enhanced by pytest):
Have you found a mitigation/solution?
No
Note: for table service, please post the issue here instead: https://github.com/Azure/azure-cosmosdb-python.