Azure / azure-storage-python

Microsoft Azure Storage Library for Python
https://azure-storage.readthedocs.io
MIT License
339 stars 241 forks source link

Please fix mypy issues #700

Open MarcSkovMadsen opened 2 years ago

MarcSkovMadsen commented 2 years ago

When running mypy on my code it fails due to azure storage blob.

The error is

c:\repos\trading_analytics\fumo-engine\.venv\lib\site-packages\azure\storage\blob\_serialize.py:129: error: Type signature has too many arguments
c:\repos\trading_analytics\fumo-engine\.venv\lib\site-packages\azure\storage\blob\_blob_client.py:1407: error: Type signature has too few arguments
c:\repos\trading_analytics\fumo-engine\.venv\lib\site-packages\azure\storage\blob\aio\_blob_client_async.py:808: error: Type signature has too few arguments

Please fix. Thanks

Santhoshkumard11 commented 2 years ago

@MarcSkovMadsen

In your mypy.ini you can specify ignoring by modules:

[mypy-tests.*]
ignore_errors = True
MarcSkovMadsen commented 2 years ago

Thanks for trying to help @Santhoshkumard11

I've added the below to my pyproject.toml, but it does not change anything.

image

MarcSkovMadsen commented 2 years ago

Ok. Changed to

image

I still would suggest fixing the underlying issue though. This is only a temporary workaround.

Santhoshkumard11 commented 2 years ago

@MarcSkovMadsen Yes, will do.

niakki commented 1 year ago

Ok. Changed to

image

I still would suggest fixing the underlying issue though. This is only a temporary workaround.

This didn't work for me, but adding a mypy.ini file with the following contents did...

[mypy-azure.*]
ignore_errors = true