search

Azure / azure-storage-ruby

Microsoft Azure Storage Library for Ruby
http://azure.github.io/azure-storage-ruby/
84 stars 150 forks source link

Resolve dependency issue for Nokogiri/Faraday #206

Closed katmsft closed 2 years ago

katmsft commented 2 years ago

Please do share your input especially if you are on the earlier versions of Ruby (below 2.5).

nertzy commented 2 years ago

This looks good to me.

grncdr commented 2 years ago

This looks fine to me, thanks for the prompt response @katmsft.

gwadej commented 2 years ago

LGTM

grosscr commented 2 years ago

LGTM - we need this too to address nokogiri vulnerabilities.

katmsft commented 2 years ago

Please reference this issue for a workaround if you have trouble using the gems: https://github.com/Azure/azure-storage-ruby/issues/196

tacoda commented 2 years ago

Excited to have this resolved! I also need to address the nokogiri vulnerabilties. Thanks!

katmsft commented 2 years ago

Since I'm not seeing any downvotes for this PR, I'll proceed and merge it and push for a release. Thanks for your feedback.