Guard against nil value for x-ms-blob-content-type

Azure / azure-storage-ruby

Microsoft Azure Storage Library for Ruby

http://azure.github.io/azure-storage-ruby/

84 stars 150 forks source link

Guard against nil value for x-ms-blob-content-type #212

Open sethboyles opened 2 years ago

sethboyles commented 2 years ago

This PR just adds usage of StorageService.with_header for x-ms-content-type, so it behaves the same as other headers.

Without this, we are having issue correctly generating the authorization signature:

AuthenticationFailed", @description: "Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.\nRequestId:3b52e87a-d01e-000a-58ac-1e4d7a000000\nTime:2022-02-10T18:35:24.3205083Z">

sethboyles commented 2 years ago

@katmsft apologies if I am tagging the wrong person. Is it possible to get this merged & released at some point? It is blocking us from getting https://github.com/fog/fog-azure-rm/ upgraded to the newer versions of azure-storage-ruby.

Thanks

MerricdeLauney commented 2 years ago

Hi @katmsft, Just checking in on this.

sethboyles commented 2 years ago

@yaxia @katmsft Could we get this looked at?