search

Azure / azure-storage-ruby

Microsoft Azure Storage Library for Ruby
http://azure.github.io/azure-storage-ruby/
84 stars 150 forks source link

Support `NO_PROXY` environment variable and fix `HTTP_PROXY/HTTPS_PROXY` behaviour #218

Open pcallewaert opened 2 years ago

pcallewaert commented 2 years ago

Hi 👋

Currently there is support for HTTP/HTTPS_PROXY behaviour. But unfortunately not for the NO_PROXY environment variable.

Faraday has native support for all the above parameters since 0.12 (https://github.com/lostisland/faraday/blob/main/CHANGELOG.md#v0120). So there is no need to configure it manually anymore.

I've update the tests so there are tests for the NO_PROXY parameter, but also noticed there was a mistake in the tests. When only HTTP_PROXY is configured, then there should be no proxy being used for https:// websites. This should be done by the HTTPS_PROXY parameter. I've updated the tests to correct this.

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.