Azure / azure-storage-ruby

Microsoft Azure Storage Library for Ruby
http://azure.github.io/azure-storage-ruby/
84 stars 150 forks source link

Upgrade Faraday to Version 2.0 #228

Open honeyankit opened 1 year ago

honeyankit commented 1 year ago

🖼️ Context

Upgrading the Faraday gem from version 1.0.0 to 2.0.

fix #227

✅ Approach

honeyankit commented 1 year ago

I was able to do the testing with command rake test:unit --trace. First I ran with the test with the original code (ie. faraday 1.0 and faraday-middleware) then I updated the Faraday to 2.0 and removed faraday-middleware and added necessary adapters and middlewares.

Note: For the unit test, I was getting same 135 failures before as well after the upgrades during the running of the unit test (rake test:unit --trace)

mhais22 commented 1 year ago

are there plans to merge this?

grncdr commented 1 year ago

These are very similar changes to what was done on my own fork. However, I don't think anybody is really actively maintaining this Gem any more.

serprex commented 1 year ago

citusdata is a Microsoft organization maintaining a fork https://github.com/citusdata/azure-storage-ruby/tree/faraday2 unfortunately when I tried looking into whether the citus team could take over maintaining this gem the email thread went nowhere

honeyankit commented 1 year ago

We had to create our own forks in the GitHub org and take the changes as Microsoft is not maintaining this repo anymore. I would be happy if they accept this PR, at-least for the short term it will unblock many folks.

Alternatively, folks can use the below below forked repo. https://github.com/honeyankit/azure-storage-ruby