search

Azure / azure-uamqp-c

AMQP library for C
Other
58 stars 62 forks source link

clang static code analyzer issues #392

Closed ericwolz closed 3 years ago

ericwolz commented 3 years ago

for SDK issue https://github.com/Azure/azure-iot-sdk-c/issues/1298

dcristoloveanu commented 3 years ago 
        if ((result == 0) && (amqpvalue_set_composite_item(error_instance->composite_value, 0, condition_amqp_value) != 0))

Likely not needed, as result is just set to 0 in ln. 140

Refers to: src/amqp_definitions.c:143 in 871aa49. [](commit_id = 871aa49f98c802f969b82d7622303b7a33122891, deletion_comment = False)

dcristoloveanu commented 3 years ago

// This file is generated. DO NOT EDIT it manually.

This file is generated with Text Transform. All changes actually should be done in the template.

Refers to: src/amqp_definitions.c:6 in 871aa49. [](commit_id = 871aa49f98c802f969b82d7622303b7a33122891, deletion_comment = False)

dcristoloveanu commented 3 years ago

// This file is generated. DO NOT EDIT it manually.

I shall Approve based on the assumption that these changes will be done in the template.

In reply to: 833098441 [](ancestors = 833098441)

Refers to: src/amqp_definitions.c:6 in 871aa49. [](commit_id = 871aa49f98c802f969b82d7622303b7a33122891, deletion_comment = False)