search

Azure / azure-uamqp-python

AMQP 1.0 client library for Python
MIT License
57 stars 48 forks source link

EH custom endpoint support #202

Closed yunhaoling closed 3 years ago

yunhaoling commented 3 years ago

add support for the Event Hub Issue https://github.com/Azure/azure-sdk-for-python/issues/16047.

eventhub PR: https://github.com/Azure/azure-sdk-for-python/pull/16295/files

I intend to hide "hostname" from the "auth" API surface first, as it's not part of the AMQP spec for a feature for EH only

yunhaoling commented 3 years ago

@annatisch , I'm a bit torn on mentioning it the release note as it's not part of the core amqp spec and it's there to support eventhub scenario.

apart from that, do you think the naming of the parameter should be more explicit such as custom_hostname, I'm afraid that the hostname is too general.

yunhaoling commented 3 years ago

conclusion: not exposing the config now, also renamed to custom_endpoint_hostname for clarity