Add azure_rm_keyvaultsecret_info module as per issue 308

Azure / azure_preview_modules

Azure preview modules for Ansible

43 stars 49 forks source link

Closed imjoseangel closed 4 years ago

Fred-sun commented 5 years ago

ready_for_review

Fred-sun commented 5 years ago

ready_for_review

Fred-sun commented 4 years ago

@mybayern1974 @haiyuazhang review_need

Fred-sun commented 4 years ago

@imjoseangel We also need to open a PR to https://github.com/ansible/ansible/pulls, Keep preview repo and devel repo in sync. Thank you very much!

Fred-sun commented 4 years ago

@haiyuazhang review_need!

imjoseangel commented 4 years ago

@imjoseangel We also need to open a PR to https://github.com/ansible/ansible/pulls, Keep preview repo and devel repo in sync. Thank you very much!

Of course. This is it → https://github.com/ansible/ansible/pull/63160 . I can ensure both modules were synced after your review.

Thank you!

devax commented 4 years ago

Would be awessome if this PR could get merged. Waiting for that functionality.

Fred-sun commented 4 years ago

@nitzmahone @haiyuazhang @gavinfish review_need!

Fred-sun commented 4 years ago

@imjoseangel Could you help resolve the conflicting files when you're free? It will push for PR meger and review! Thank you very much!

imjoseangel commented 4 years ago

@Fred-sun Test are failing when creating a VM, not because the module. Please confirm this can be merged too.

Thanks

Fred-sun commented 4 years ago

@imjoseangel It has been moved to #50 and merged. Can you close it? Thank you very much!