search

Azure / azurefile-dockervolumedriver

Docker Volume Driver for Azure File Service over SMB/CIFS :whale:
Apache License 2.0
169 stars 55 forks source link

Upstart init scripts and docs #11

Closed ahmetb closed 8 years ago

ahmetb commented 8 years ago

cc:@colemickens

ahmetb commented 8 years ago

actually I need to double check if the plugin drivers should start before or after docker service.

In any case the socket check might be necessary, though I'm not sure how can I do that with curl.

colemickens commented 8 years ago

If you just want to wait for the existence of the tcp socket file you create, you can just do it like docker, I don't think you need curl. https://github.com/docker/docker/blob/master/contrib/init/upstart/docker.conf#L60

ahmetb commented 8 years ago

Alright, removing filesystem from start on fixed it! Thanks @colemickens.

ahmetb commented 8 years ago

I'm not going to wait on socket creation to call it "started", because (1) that doesn't necessarily indicate handlers are up and running (2) apparently docker engine retries with exponential back-off for plugins, so it should essentially succeed pretty easily.