search

Azure / azurefile-dockervolumedriver

Docker Volume Driver for Azure File Service over SMB/CIFS :whale:
Apache License 2.0
169 stars 55 forks source link

incorrect names in defaults for systemd setup #38

Closed bertvannuffelen closed 8 years ago

bertvannuffelen commented 8 years ago

Dear, in https://github.com/Azure/azurefile-dockervolumedriver/blob/master/contrib/init/systemd/azurefile-dockervolumedriver.default the parameters are called AZURE_STORAGE_ACCOUNT= AZURE_STORAGE_ACCOUNT_KEY=

while only these are being loaded AF_ACCOUNT_NAME= AF_ACCOUNT_KEY=

kr,

Bert

ahmetb commented 8 years ago

@bertvannuffelen this should not be an issue. the program actually looks for AZURE keys. It's just the upstart script that has the AF keys (and that's for the backwards compatibility reasons).

Are you seeing a different behavior?

bertvannuffelen commented 8 years ago

When I copied the systemd service description and the configuration file next to it to the target locations the driver did not start. When adding the above parameters it started all fine.

(behaviour experienced on on an Ubuntu Xenial and ubuntu 15.04 )

ahmetb commented 8 years ago

@bertvannuffelen are you sure you don't have an instance of upstart also running on your system?

The code does not even have anything mentioning AF_ variables:

https://github.com/Azure/azurefile-dockervolumedriver/blob/master/main.go

are you using the latest version in the Releases tab?

bertvannuffelen commented 8 years ago

I am building the driver from source. And then copy the service descriptions.

kr,

Bert

ahmetb commented 8 years ago

@bertvannuffelen I just tried it with 0.2.1 binary release (I'm confident we haven't changed the code for this) and followed instructions at https://github.com/Azure/azurefile-dockervolumedriver/blob/master/contrib/init/systemd/README.md and it worked for me on Ubuntu 16.04.

Can you please try with 16.04? The 15.04 is not supported since February 2016. https://wiki.ubuntu.com/Releases