search

Azure / azurefile-dockervolumedriver

Docker Volume Driver for Azure File Service over SMB/CIFS :whale:
Apache License 2.0
169 stars 55 forks source link

Add RemotePath mount option #46

Closed zlatan closed 8 years ago

zlatan commented 8 years ago

I add an option remotepath which will allow us to use a specific directory in File Share as a volume in the docker container.

ahmetb commented 8 years ago

The word remotepath sounds a bit confusing to me. It took me several minutes to understand what it does. Is this part of the SMB/Azure File Storage terminology or did you come up with it?

Also did you test this change?

zlatan commented 8 years ago

RemotePath is part of the terminology of SMB (cf. https://technet.microsoft.com/en-us/library/jj635724(v=wps.630).aspx ). The code of pull request is tested and work properly.

ahmetb commented 8 years ago

@zlatan I just took a major bugfix on the master branch. Do you mind rebasing and ping me when you do?

zlatan commented 8 years ago

@ahmetalpbalkan Rebase is ready.

ahmetb commented 8 years ago

@zlatan mostly looks good, thank you very much. Can you please document it in README.md as well (especially since the terminology is a bit hard to understand in this case)?

zlatan commented 8 years ago

@ahmetalpbalkan README.md was updated, path.Join was used for concatenation of remotepath to mountURI.

ahmetb commented 8 years ago

@zlatan thanks for following up. merging.

zlatan commented 8 years ago

@ahmetalpbalkan Thank you!