search

Azure / azurestack-powershell

AzureStack Hub Operator Powershell Cmdlets
MIT License
16 stars 33 forks source link

[2203] Add PS Cmdlets for VPN Admin API #151

Closed iancaragol closed 2 years ago

iancaragol commented 2 years ago

The main new addition is the Get-AzSVirtualNetworkGatewayConnection cmdlet which uses talks to NRP to list all VPN resources created on the stamp.

As part of the generation for this cmdlet, many other files were updated as well. The docs MD file for each of the other cmdlet has a new format.

Please let me know if I need to remove these updates.

Thanks!

iancaragol commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Commenter does not have sufficient privileges for PR 151 in repo Azure/azurestack-powershell
bganapa commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 3 pipeline(s).
iancaragol commented 2 years ago

Update module version and the changelog. code review checklist has pointers https://github.com/Azure/azurestack-powershell/wiki/Code-Review-Check-List

Thanks @bganapa! I bumped the module version from 1.0.2 to 1.1.0 and also updated the changelog.md

TheOnlyWei commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 3 pipeline(s).
iancaragol commented 2 years ago

@TheOnlyWei It looks like the CI run failed on the Backup.Admin tests. This should be unrelated to my changes. Is it a known issue?

TheOnlyWei commented 2 years ago

@iancaragol

@TheOnlyWei It looks like the CI run failed on the Backup.Admin tests. This should be unrelated to my changes. Is it a known issue?

Yes, it is a known issue. Backup RP is attempting to revert their changes due to some issues, don't know about ETA. I can force merge your changes as long as you haven't made changes to the RP that is failing.

iancaragol commented 2 years ago

Hi @TheOnlyWei

We would prefer to go the force merge route if that is OK with you. That way everything is checked in and ready to go. I have only made changes within the AzS.Network.Admin space

Thanks!

TheOnlyWei commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 3 pipeline(s).