Azure / batch-insights

One liners to enable Application insights on azure batch
MIT License
24 stars 16 forks source link

Add support for monitoring specific processes #29

Closed Porges closed 5 years ago

Porges commented 5 years ago

Add a new commandline parameter which is a comma-separated list of process names to monitor. Stats for CPU and memory of these processes will be sent alongside the other metrics.

timotheeguerin commented 5 years ago

Can you also add docs to the readme on how to use this setting

Porges commented 5 years ago

Updated docs.

timotheeguerin commented 5 years ago

On windows you also need to update the run-windows.ps1 because of the way it starts background tasks environment variables are not passed through so they have to be converted to cli args

Porges commented 5 years ago

@timotheeguerin yes, that's why I wrote "this will require modifying the appropriate run script". Do you think I should be more explicit?

timotheeguerin commented 5 years ago

Oh I see, any reason why you wouldn't change it here? Feel like this is an unnecessary step for users

Porges commented 5 years ago

Right, easy enough 🙂