Azure / bicep-registry-modules

Bicep registry modules
MIT License
460 stars 305 forks source link

[AVM Question/Feedback]: VM extension #1067

Closed Gijsreyn closed 5 months ago

Gijsreyn commented 6 months ago

Check for previous/existing GitHub issues

Description

Dear AVM maintainers,

While deploying the Azure Virtual Machine, it is required to perform a domain join (AD). In the extension, you can of course set the restarted setting to false, as such:

extensionDomainJoinConfig: {
      enabled: true
      settings: {
        name: '' 
        user: '
        restart: 'false' // setting
        options: 3
        ouPath:
      }
    }

But the virtual machine needs to be restarted anyway and this is particularly helpful when doing post deployment task. The only thing that I'm looking for, is that after the domain join has happened, the custom script extension sometime fails if you combine them (because of the restart). Is it possible to do a "dependsOn"?

Another extension that I was missing, was the GuestConfiguration extension. Are there any plans on adding it to the VM?

Thanks in advance.

AlexanderSehr commented 6 months ago

@Gijsreyn can't argue with the asks. What's your take @rahalan ?

rahalan commented 6 months ago

Good idea. I will look into that. There are also some other extensions that I want to add.

rahalan commented 6 months ago

@matebarabas why are those warnings coming, I already answered?

AlexanderSehr commented 6 months ago

It'll be added time and time again if I'm not mistaken

matebarabas commented 6 months ago

Not anymore, as once the "Needs: triage" label is removed, the bot will not say a single thing again. 😉👍

rahalan commented 5 months ago

@Gijsreyn FYI, PR is nearly done. Currently I am unfortunately blocked by a bug in the readme generation. I expect it to be solved in the next days. After that, I will promote the PR, so it can be reviewed.

Gijsreyn commented 5 months ago

@rahalan Love the work you did!

rahalan commented 5 months ago

@Gijsreyn PR is finally merged