search

Azure / bicep-registry-modules

Bicep registry modules
MIT License
412 stars 274 forks source link

[AVM Module Issue]: Cognitive Service should add the creation of 'Microsoft.CognitiveServices/accounts/deployments' #1131

Closed Menghua1 closed 2 months ago

Menghua1 commented 3 months ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/cognitive-services/account

(Optional) Module Name if not listed above

avm/res/cognitive-services/account

(Optional) Module Version

No response

Description

Please add the creation of 'Microsoft.CognitiveServices/accounts/deployments'. For example (azd): https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/ai/cognitiveservices.bicep#L38

CC: @jongio

(Optional) Correlation Id

No response

github-actions[bot] commented 3 months ago

@Menghua1, thanks for submitting this issue for the avm/res/cognitive-services/account module!

A member of the @azure/avm-res-cognitiveservices-account-module-owners-bicep or @azure/avm-res-cognitiveservices-account-module-contributors-bicep team will review it soon!

ilhaan commented 3 months ago

@Menghua1 thanks for submitting this. I will take a look at this and make an update soon

jongio commented 3 months ago

@ilhaan - Did you get a chance to take a look?

microsoft-github-policy-service[bot] commented 3 months ago

[!NOTE] The "Type: AVM :a: :v: :m:" label was added as per ITA08BCP.

jongio commented 3 months ago

@v-xuto @zedy-wj - Can you please submit a PR to AVM for this feature?

zedy-wj commented 3 months ago

@jongio - We have done a PR for this issue. PR link: https://github.com/Azure/bicep-registry-modules/pull/1466, please review it, thanks!

ilhaan commented 2 months ago

@jongio Apologies for the delay as I was OOF. I have reviewed the PR and left a couple comments for @zedy-wj.

CC: @jceval