Azure / bicep-registry-modules

Bicep registry modules
MIT License
506 stars 351 forks source link

[WAF - Reliability Review] - `avm/res/app-configuration/configuration-store` #1502

Closed jtracey93 closed 6 months ago

jtracey93 commented 7 months ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/app-configuration/configuration-store

(Optional) Module Name if not listed above

No response

(Optional) Module Version

No response

Description

Hello team,

The AVM core team are performing a review of all AVM modules to ensure they are aligned to the WAF reliability pillar by default, and in the future they will be checking against other WAF pillars also. This is a requirement we have before we can go v1.0.0 for any AVM module.

Links to AVM specs:

Links to WAF Reliability, APRL & Product Docs recommendations used for analysis:

Whilst reviewing this module the following issues have been found that are non-compliant with the AVM specs that need to be resolved in a new version release that can be seen in the PSRule for Azure run here: https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.app-configuration.configuration-store.yml#summary-23300173139

The geo-replica PSRule check may need a suppression rule creating as it may only be suitable for a pattern module and not a resource module. The AVM .ps-rule directory can be found here: https://github.com/Azure/bicep-registry-modules/tree/main/avm/utilities/pipelines/staticValidation/psrule/.ps-rule

Please make these changes in a PR to the parameter defaults so a new minor version can be published.

Thanks

The AVM Core Team

(Optional) Correlation Id

No response

matebarabas commented 7 months ago

Note, this module is currently orphaned: https://github.com/Azure/Azure-Verified-Modules/issues/731

segraef commented 7 months ago

Seems "Microsoft.AppConfiguration/configurationStores/replicas" needs to be added.

eriqua commented 6 months ago

@JFolberth is actively working on fixing this issue through PR #1696

microsoft-github-policy-service[bot] commented 6 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.

[!NOTE] This message was posted as per ITA02BCP.