Azure / bicep-registry-modules

Bicep registry modules
MIT License
460 stars 304 forks source link

[AVM Module Issue]: FunctionApp Can't Be Deployed when on Consumption #1797

Open jreinhardtproarch opened 4 months ago

jreinhardtproarch commented 4 months ago

Check for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/web/site

(Optional) Module Version

0.3.4

Description

This claims to be able to deploy a FunctionApp. However, the default appSettings it deploys only include the storage setting WebSiteJobsStorage (see main.bicep line 72. This means that, per https://learn.microsoft.com/en-us/azure/azure-functions/functions-recover-storage-account#storage-account-application-settings-were-deleted, this template assumes that an Elastic Premium and Consumption plan are not being used as per that link.

I would propose that the template be updated to ensure that the connection string appSetting WEBSITE_CONTENTAZUREFILECONNECTIONSTRING is deployed if a consumption app or elastic premium server farm is linked and that the file share is also created in the linked storage account with a corresponding appSetting WEBSITE_CONTENTSHARE. Is this doable?

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 4 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

[!NOTE] This label was added as per ITA06.

microsoft-github-policy-service[bot] commented 4 months ago

[!NOTE] The "Type: Bug :bug:" label was added as per ITA21.

avm-team-linter[bot] commented 4 months ago

@jreinhardtproarch, thanks for submitting this issue for the avm/res/web/site module!

[!IMPORTANT] A member of the @Azure/avm-res-web-site-module-owners-bicep or @Azure/avm-res-web-site-module-contributors-bicep team will review it soon!

tsc-buddy commented 4 months ago

Hi @jreinhardtproarch thanks for submitting the issue. We shall schedule some triage time in for later in May to take a look at this. Thanks Again.

IngerMathilde commented 1 month ago

Hi! Any update on this issue?