search

Azure / bicep-registry-modules

Bicep registry modules
MIT License
509 stars 357 forks source link

[AVM Module Issue]: Support API Server VNet Integration in `container-service/managed-cluster` #1923

Open coolhome opened 6 months ago

coolhome commented 6 months ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/container-service/managed-cluster

(Optional) Module Version

No response

Description

https://learn.microsoft.com/en-us/azure/aks/api-server-vnet-integration

Below is what I've been using locally and it's been working pretty well 🧑‍🚒 

@description('Optional. Enable API Server vnet integration. Requires subscription feature flag `EnableAPIServerVnetIntegrationPreview` to be enabled during preview.')
param enableApiServerVnetIntegration bool = false

@description('Optional.  API Server subnet resource id.')
param apiServerSubnetResourceId string?
    apiServerAccessProfile: {
      authorizedIPRanges: authorizedIPRanges
      disableRunCommand: disableRunCommand
      enablePrivateCluster: enablePrivateCluster
      enablePrivateClusterPublicFQDN: enablePrivateClusterPublicFQDN
      privateDNSZone: privateDNSZone

      // START MOD
      enableVnetIntegration: enableApiServerVnetIntegration
      subnetId: apiServerSubnetResourceId
      // END MOD
    }

(Optional) Correlation Id

No response

avm-team-linter[bot] commented 6 months ago

@coolhome, thanks for submitting this issue for the avm/res/container-service/managed-cluster module!

[!IMPORTANT] A member of the @Azure/avm-res-containerservice-managedcluster-module-owners-bicep or @Azure/avm-res-containerservice-managedcluster-module-contributors-bicep team will review it soon!

PixelRobots commented 6 months ago

I think we should add this once the feature has gone GA, which will hopefully happen soon.

I also think we should add a new test deployment for this too.

AlexanderSehr commented 6 months ago

I think we should add this once the feature has gone GA, which will hopefully happen soon.

I also think we should add a new test deployment for this too.

I'd argee and it would also align with the repository's specs. It's technically not forbidden - but not encouraged 😉 @JPEasier, what's your take?

microsoft-github-policy-service[bot] commented 5 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!

[!NOTE] This message was posted as per ITA01BCP.

microsoft-github-policy-service[bot] commented 5 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.

[!NOTE] This message was posted as per ITA02BCP.

microsoft-github-policy-service[bot] commented 5 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!

[!NOTE] This message was posted as per ITA01BCP.

microsoft-github-policy-service[bot] commented 5 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.

[!NOTE] This message was posted as per ITA02BCP.

microsoft-github-policy-service[bot] commented 5 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!

[!NOTE] This message was posted as per ITA01BCP.

microsoft-github-policy-service[bot] commented 5 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.

[!NOTE] This message was posted as per ITA02BCP.

microsoft-github-policy-service[bot] commented 5 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 5 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.
AlexanderSehr commented 5 months ago

Hey @JPEasier, could you please triage the issue 💪

JPEasier commented 5 months ago

Hey @coolhome,

i think we should implement your suggestion 🚀 this feature definitely makes sense. Nevertheless this is a preview feature and we need to make sure that it is marked as such.

@AlexanderSehr do we have conventions for AVM for preview features, for example key words in description?

AlexanderSehr commented 5 months ago

Hey @coolhome,

i think we should implement your suggestion 🚀 this feature definitely makes sense. Nevertheless this is a preview feature and we need to make sure that it is marked as such.

@AlexanderSehr do we have conventions for AVM for preview features, for example key words in description?

Hey @JPEasier, in fact we do: https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-sfr1---category-composition---preview-services

coolhome commented 5 months ago

I fully agree @JPEasier this needs to be clearly marked. Thank you @AlexanderSehr for always getting the ball moving 🙌