Azure / bicep-registry-modules

Bicep registry modules
MIT License
399 stars 269 forks source link

[AVM Module Issue]: diagnosticSettings for the module does not work #1938

Open zboukheloua opened 1 month ago

zboukheloua commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/desktop-virtualization/workspace

(Optional) Module Version

0.4.0

Description

I have the following diagnostic settings for the Workspace resource:

diagnosticSettings: [
      {
        workspaceResourceId: LogWorkspace.outputs.resourceId
        name: workSpaceDiagName
        logCategoriesAndGroups: [
          {
            categoryGroup: 'allLogs'
          }
        ]
      }
    ]

I have also tried:

    diagnosticSettings: [
      {
        name: workSpaceDiagName
        workspaceResourceId: LogWorkspace.outputs.resourceId
        logCategoriesAndGroups: [
          {
            category: 'Checkpoint'
          }
          {
            category: 'Error'
          }
          {
            category: 'Management'
          }
          {
            category: 'Feed'
          }
        ]
      }
    ]

Both do not work. The diagnostic settings of the Workspace resource stays empty. If I manually set up diagnostic settings trough the Azure portal for the Workspace resource and deploy the module again, it removes the manually set up configuration.

I have deployed a new Workspace resource and get the same results.

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

[!NOTE] This label was added as per ITA06.

microsoft-github-policy-service[bot] commented 1 month ago

[!NOTE] The "Type: Bug :bug:" label was added as per ITA21.

avm-team-linter[bot] commented 1 month ago

@zboukheloua, thanks for submitting this issue for the avm/res/desktop-virtualization/workspace module!

[!IMPORTANT] A member of the @Azure/avm-res-desktopvirtualization-workspace-module-owners-bicep or @Azure/avm-res-desktopvirtualization-workspace-module-contributors-bicep team will review it soon!

moisesjgomez commented 1 month ago

Thanks for reporting this bug. Will review it.

microsoft-github-policy-service[bot] commented 3 weeks ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!

[!NOTE] This message was posted as per ITA01BCP.

AlexanderSehr commented 3 weeks ago

Very strange indeed. Thanks @moisesjgomez for looking into it - I can't see any obvious issue with the deployment. I guess to troubleshoot we'd need to deploy one of the test cases with diagnosticSettings manually and try to replicate it

microsoft-github-policy-service[bot] commented 3 weeks ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.

[!NOTE] This message was posted as per ITA02BCP.

microsoft-github-policy-service[bot] commented 2 weeks ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.

[!NOTE] This message was posted as per ITA02BCP.

moisesjgomez commented 2 weeks ago

Following up on this as I haven't resolved yet but should have more updates the following week.

moisesjgomez commented 3 days ago

Hello team due to current priorities I've not been able to get to the bottom of this. I will follow up again next week as I should have some more time. Thanks.