Azure / bicep-registry-modules

Bicep registry modules
MIT License
414 stars 274 forks source link

[AVM Module Issue]: avm/res/network/virtual-network multiple addressPrefixes/enable ipv6 #2020

Open DeuxFils opened 1 month ago

DeuxFils commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/network/virtual-network

(Optional) Module Version

0.1.6

Description

To enable ipv6 you have to provide multiple addressPrefixes. For example this bicep:

module virtualNetworkHub 'br/public:avm/res/network/virtual-network:0.1.6' = {
  name: 'virtualNetworkHubDeployment'
  params: {
    name: 'vnet-ipv6-test'
    addressPrefixes: [
      '10.189.200.0/21'
      '2001:DB8:200::/56'
    ]
    subnets: [
      {
        name: 'vsub-ipv6-test'
        addressPrefixes: [
          '10.189.200.0/24'
          '2001:DB8:200:1::/64'          
        ]
      }
    ]
  }
}

This results in the following error.

[...]Status Message: The template output 'subnetAddressPrefixes' is not valid: The language expression property 'addressPrefixes' doesn't exist, available properties are 'provisioningState, addressPrefix, serviceEndpoints, delegations,
privateEndpointNetworkPolicies, privateLinkServiceNetworkPolicies'[...]

It seem there is no way to enable ipv6 on the subnet. Notice ther is a (preview) which allows to have multiple addressPrefixes for a subnet. Link.

(Optional) Correlation Id

No response

avm-team-linter[bot] commented 1 month ago

@DeuxFils, thanks for submitting this issue for the avm/res/network/virtual-network module!

[!IMPORTANT] A member of the @Azure/avm-res-network-virtualnetwork-module-owners-bicep or @Azure/avm-res-network-virtualnetwork-module-contributors-bicep team will review it soon!

cloudchristoph commented 1 month ago

As this is still a Preview Feature - quote:

Multiple prefix support for Azure Virtual Network subnets is currently in public preview.

...is it worth to implement this feature?

DeuxFils commented 1 month ago

The underlying bicep API has support for multiple addressPrefixes for a long time. I think the only usefull usecase till now is when you have one IPv4 and one IPv6 prefix. This is the way to enable IPv6 on the subnet.

In the future it is possible to have one or more IPv4 prefixes and optional one IPv6 range. I don't expect multiple IPv6 ranges are usefull.

I believe when this bug is fixed, multiple IPv4 prefixes are supported/implemented as well. Eventhough this is a preview feature.

microsoft-github-policy-service[bot] commented 3 weeks ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 3 weeks ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.
AlexanderSehr commented 3 weeks ago

Hey @elbatane, please take a look when you can

microsoft-github-policy-service[bot] commented 3 weeks ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 3 weeks ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.
microsoft-github-policy-service[bot] commented 2 weeks ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 2 weeks ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.
AlexanderSehr commented 2 weeks ago

ping @elbatane

elbatane commented 2 weeks ago

Hi, thank you for open the issue. We will review and add this functionality. Thank you