Azure / bicep-registry-modules

Bicep registry modules
MIT License
417 stars 277 forks source link

[Bicep-Virtual Machine Scale set AVM Review Feedback by VMSS PG] Best practices to be followed #2304

Open Kanik09 opened 3 weeks ago

Kanik09 commented 3 weeks ago

Please follow the below best practices for the corresponding modules. Not all practices should be followed for both default and max.

 

VMSS Best Practice Applicable AVM Module Applicable for Default Applicable for Max
Deploy VMSS with Flex Orchestration mode Terraform, Bicep Yes Yes
Configure VMSS autoscale to custom and configure scaling metrics Terraform, Bicep No Yes
Configure Predictive autoscale and atleast for forecast only Terraform, Bicep No Yes
Deploy VMSS across availaibility zones with VMSS flex Terraform, Bicep Yes Yes
Disable Force strictly even balance across zones to avoid scale in and out fail attempts Terraform, Bicep Yes Yes
Enable VMSS application health monitoring Terraform, Bicep Yes if condition shared over Email is met.  Yes if condition shared over Email is met. 
Enable Automatic Repair Policy Terraform, Bicep Requires health monitoring to be enabled. Requires health monitoring to be enabled. 
Set Patch orchestration options to Azure-orchestrated Terraform, Bicep Yes Yes
Upgrade VMSS Image versions scheduled to be deprecated or already retired Terraform, Bicep    
Configure Allocation Policy Spreading Algorithm to max spreading Terraform, Bicep Yes Yes
microsoft-github-policy-service[bot] commented 3 weeks ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

rahalan commented 3 weeks ago

@Kanik09 thank you. I will look into it