search

Azure / bicep-registry-modules

Bicep registry modules
MIT License
430 stars 286 forks source link

[AVM Module Issue]: AVM Host Pool Schedules #2308

Open MikeHirtWB opened 1 month ago

MikeHirtWB commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/desktop-virtualization/scaling-plan

(Optional) Module Version

0.1.1

Description

The AVM for Host pools does not support creating schedules for personal Host Pools.

Currently the modules are using the "2022-09-09" version of the API. This API version does not support creating scaling plan for personal host pools. Seeing as the rest of the AVD Azure Verified Modules support creating personal host pools, the scaling plans should do the same.

The first non preview API that supports the personal scaling plan schedules is "2023-09-05", breaking the personal host pool schedule type into its own API of Microsoft.DesktopVirtualization scalingPlans/personalSchedules

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 1 month ago

@MikeHirtWB, thanks for submitting this issue for the avm/res/desktop-virtualization/scaling-plan module!

[!IMPORTANT] A member of the @Azure/avm-res-desktopvirtualization-scalingplan-module-owners-bicep or @Azure/avm-res-desktopvirtualization-scalingplan-module-contributors-bicep team will review it soon!

avm-team-linter[bot] commented 1 month ago

[!WARNING] This issue couldn't be assigend due to an internal error. @danycontre, please make sure this issue is assigned to you and please provide an initial response as soon as possible, in accordance with the AVM Support statement.

danycontre commented 1 month ago

@MikeHirtWB we are checking the issue and will get back to you.

danycontre commented 1 month ago

Feature request been addressed by PR 2347 https://github.com/Azure/bicep-registry-modules/pull/2347/files

danycontre commented 1 month ago

Pushing additional updates to separate APi calls of scaling plan creation from schedules definitions, this will account for Personal and pooled host pool type scenarios.