Azure / bicep-registry-modules

Bicep registry modules
MIT License
506 stars 351 forks source link

[AVM Module Issue]: avm/res/network/vpn-gateway #2348

Open rickvdboor opened 4 months ago

rickvdboor commented 4 months ago

Check for previous/existing GitHub issues

Issue Type?

I'm not sure

Module Name

avm/res/network/vpn-gateway

(Optional) Module Version

0.1.2

Description

I'm trying to deploy vwan with hubs, vpnsites and vpnconnections.

Previously if i'd deploy the vpn gateway and keep vpnconnections empty, it'd leave the existing connections alone. But now my vpnconnections are removed when enrolling the vpn gateway.

I have been looking and searching for decent documentation on how to configure the vpnConnections parameter but i'm unable to find any. Perhaps someone here can help me? This is my module: module vpnGatewayEU 'br/public:avm/res/network/vpn-gateway:0.1.2' = if (deployvpngw) { scope: resourceGroup(SubscriptionID, vwanrg) name: 'vpngwDeployment-eu' params: { name: 'vpngw-1324124124' enableBgpRouteTranslationForNat: true location: 14124124 virtualHubResourceId: virtualHubEU.outputs.resourceId vpnGatewayScaleUnit: 1 bgpSettings: { asn: 65515 peerWeight: 0 bgpPeeringAddresses: [ { ipconfigurationId: 'Instance0' defaultBgpIpAddresses: [ '172.30.0.12' ] customBgpIpAddresses: ['169.254.21.1'] tunnelIpAddresses: [ '98.**.***.160' '172.30.0.20' ] } { ipconfigurationId: 'Instance1' defaultBgpIpAddresses: [ '172.30.0.13' ] customBgpIpAddresses: ['169.254.22.1'] tunnelIpAddresses: [ '98.**.***.161' '172.30.0.21' ] } ] } tags: { Createdby: bicepTags.CreatedBy Environment: environmentType Owner: bicepTags.Owner Business: bicepTags.Business } } dependsOn: [ virtualHubEU ] } Here i create my vpnsites with links: module vpnSitetoSiteEU 'br/public:avm/res/network/vpn-site:0.1.3' = [ for vpnSite in s2seu: { scope: resourceGroup(SubscriptionID, vwanrg) name: 'vpnSiteDeployment-${vpnSite.name}-EU' params: { name: vpnSite.name virtualWanId: virtualWan.outputs.resourceId deviceProperties: vpnSite.deviceProperties vpnSiteLinks: vpnSite.vpnSiteLinks location: location** tags: { Createdby: bicepTags.CreatedBy Environment: environmentType Owner: bicepTags.Owner Business: bicepTags.Business } } dependsOn: [ virtualWan ] } ]

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 4 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 4 months ago

@rickvdboor, thanks for submitting this issue for the avm/res/network/vpn-gateway module!

[!IMPORTANT] A member of the @Azure/avm-res-network-vpngateway-module-owners-bicep or @Azure/avm-res-network-vpngateway-module-contributors-bicep team will review it soon!

microsoft-github-policy-service[bot] commented 4 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
AlexanderSehr commented 4 months ago

Hey @fabmas, please take a look and triage the issue when you get the chance :)

microsoft-github-policy-service[bot] commented 4 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 4 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.
fabmas commented 4 months ago

Hi, sorry for the late response. I'll investigate this issue asap.