Azure / bicep-registry-modules

Bicep registry modules
MIT License
474 stars 331 forks source link

[Bug Report]: Microsoft.Network/vpnGateways/connections] `ConnectionBandwidth` property has been deprecated #2375

Closed chris5287 closed 2 weeks ago

chris5287 commented 2 years ago

Describe the bug

It appears the ConnectionBandwidth property has been deprecated, but the ARM docs haven't been updated here: https://docs.microsoft.com/en-us/azure/templates/microsoft.network/vpngateways/vpnconnections?tabs=bicep#vpnconnectionproperties

This means deployments fail and there is no way to use the module as it has a default value in the bicep file :(

To reproduce

https://github.com/Azure/ResourceModules/blob/80c29bd5fef1d522354b801b6bb59106e74ad67c/modules/Microsoft.Network/vpnGateways/connections/deploy.bicep#L38

https://github.com/Azure/ResourceModules/blob/80c29bd5fef1d522354b801b6bb59106e74ad67c/modules/Microsoft.Network/vpnGateways/connections/deploy.bicep#L76

Code snippet

module vpnc 'main/modules/Microsoft.Network/vpnGateways/connections/deploy.bicep' = {
  name: '${deployment().name}_vpnc'
  params: {
    name: 'vpnGatewayConnection'
    vpnGatewayName: 'vpnGateway'
    remoteVpnSiteResourceId: 'remoteVpnSiteResourceId'
    vpnLinkConnections: [...]
  }
}

Relevant log output

{
    "status": "Failed",
    "error": {
        "code": "VpnConnectionPropertyIsDeprecated",
        "message": "Update request for VpnConnection /subscriptions/....../resourceGroups/..../providers/Microsoft.Network/vpnGateways/..../vpnConnections/.... contains deprecated property ConnectionBandwidth. Please use corresponding VpnSiteLinkConnection property instead.",
        "details": []
    }
}
krbar commented 2 years ago

I will investigate this bug

krbar commented 2 years ago

@chris5287 I'm having trouble reproducing the issue. The module deployment using module pipeline worked for me, also changing the "ConnectionBandwidth" property was successful. Can you please share more details, which could help me to reproduce the issue? For example: In which region are you deploying, are you using the latest version of the modules?

chris5287 commented 2 years ago

I was using 0.6.0 deploying into the uksouth and canadacentral regions

AlexanderSehr commented 3 months ago

Hey @fabmas, I just migrated this issue from CARML. Please take a look an triage. Maybe it's not relevant anymore :)

AlexanderSehr commented 2 months ago

Hey @fabmas, please take a moment to triage this issue if you can 💪

fabmas commented 2 months ago

Hey, sorry for the delay. I'm currently restructuring the entire module introducing new UDTs. I'll take care of this issue in the next release of the module.

AlexanderSehr commented 2 months ago

Hey @fabmas, thanks. Just note that the CI's automation (bot) will continue to comment and ping you until the labels Needs: Triage and Status: Response Overdue are removed 😉

fabmas commented 2 weeks ago

This issue is no more relevant.