search

Azure / bicep-registry-modules

Bicep registry modules
MIT License
507 stars 352 forks source link

[Feature Request]: Align NAT Gateway Public IP implementation with e.g. Bastion & Azure Firewall #2378

Closed AlexanderSehr closed 1 month ago

AlexanderSehr commented 1 year ago

Description

The implementation of the NAT Gateway Public IP differs a lot from the other resources which introduces quite some inconsistency.

This is partly rooted in the fact that the NAT Gateway can have multiple Public IPs & alternative multiple Public IP Prefixes.

We should anyways align the approach and, for example, allow the user to either specify an array of Public IPs, or provide the configuration to create multiple Public IPs (- the same for prefixes).

rahalan commented 1 year ago

ref: Azure Bastion and Azure Firewall

microsoft-github-policy-service[bot] commented 5 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

AlexanderSehr commented 5 months ago

Hey @fabmas, I just migrated this issue from CARML. Please take a look if it's still relevant and triage :)

fabmas commented 1 month ago

Hi @AlexanderSehr The module appears to be updated with the correct Public IP implementation version. I have included a test case that demonstrates the method for utilizing an existing Public IP by referencing its resourceID. The PR for the update is #3341