search

Azure / bicep-registry-modules

Bicep registry modules
MIT License
472 stars 328 forks source link

[AVM Module Issue]: MySQL Flexible Server Module should add the output `mysqlServer.properties.fullyQualifiedDomainName` #2576

Closed Menghua1 closed 2 months ago

Menghua1 commented 3 months ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/db-for-my-sql/flexible-server

(Optional) Module Version

No response

Description

Please add the output mysqlServer.properties.fullyQualifiedDomainName.

For example (azd): https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/database/mysql/flexibleserver.bicep#L65

CC: @jongio

(Optional) Correlation Id

No response

avm-team-linter[bot] commented 3 months ago

@Menghua1, thanks for submitting this issue for the avm/res/db-for-my-sql/flexible-server module!

[!IMPORTANT] A member of the @Azure/avm-res-dbformysql-flexibleserver-module-owners-bicep or @Azure/avm-res-dbformysql-flexibleserver-module-contributors-bicep team will review it soon!

v-xuto commented 3 months ago

@hundredacres We have created a PR for this issue. Please review.

microsoft-github-policy-service[bot] commented 2 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 2 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 2 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.
microsoft-github-policy-service[bot] commented 2 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 2 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.
AlexanderSehr commented 2 months ago

Hey @hundredacres, please take a moment to triage this issue if you can 💪

microsoft-github-policy-service[bot] commented 2 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 2 months ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.
hundredacres commented 2 months ago

I've opened a bug here: https://github.com/Azure/bicep-types-az/issues/2239

Appears to be an issue when passing a maintenanceWindow object, which is a WAF required setting.

AlexanderSehr commented 2 months ago

I've opened a bug here: Azure/bicep-types-az#2239

Appears to be an issue when passing a maintenanceWindow object, which is a WAF required setting.

Hey @hundredacres, and this only happens when adding the output requested in this issue?

hundredacres commented 2 months ago

@AlexanderSehr If we just add the requested output and remove the maintenanceWindow object from the default and WAF tests, then we're green again. But the maintenanceWindow object is required by WAF, so not having the param present causes a Pester test to fail. If there's a way to bypass a specific WAF test, we could merge this change and wait for a response to my bug.

hundredacres commented 2 months ago

@AlexanderSehr The pipeline from this PR fails cause the maintenanceWindow object is missing from the default test, which throws this Pester error

Error: AZR-000431: ***dfmsfsmin001 failed Azure.MySQL.MaintenanceWindow. Configure a customer-controlled maintenance window for Azure Database for MySQL servers.

AlexanderSehr commented 2 months ago

Hey @hundredacres, thanks for the input. Just got a bit confused as this issue doesn't mention anything about the maintenanceWindow, but looking at the PR I saw now that you're referring to the PSRule tests. Will reply on the PR then instead :)