search

Azure / bicep-registry-modules

Bicep registry modules
MIT License
460 stars 305 forks source link

[AVM Module Issue]: ApiManagement is missing module service/products/policies #2618

Open mikejonestechno opened 2 months ago

mikejonestechno commented 2 months ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/api-management/service

(Optional) Module Version

No response

Description

AVM v0.2.0 supports both service/policies and service/apis/policies but not service/products/policies so bicep authors need to create all the product policies as bicep resources separate from the AVM, for example:

resource internalproductpolicy 'Microsoft.ApiManagement/service/products/policies@2023-05-01-preview' = {
  name: '${apimName}/Internal/policy'
  dependsOn: [apim]
  properties: {
    value: loadTextContent('../policies/internal-product-policy.xml')
  }
}

Feature Request

Add the service/products/policies sub-module to the AVM. Should be reasonably straightforward as very similar to service/apis/policies

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 2 months ago

@mikejonestechno, thanks for submitting this issue for the avm/res/api-management/service module!

[!IMPORTANT] A member of the @Azure/avm-res-apimanagement-service-module-owners-bicep or @Azure/avm-res-apimanagement-service-module-contributors-bicep team will review it soon!

tony-box commented 2 months ago

@mikejonestechno thank you for the suggestion. I will get to this into my next PR where I am adding a few more new features.