search

Azure / bicep-registry-modules

Bicep registry modules
MIT License
428 stars 284 forks source link

[AVM Question/Feedback]: servicebus/namespace/topics/subcriptions/rules not availble? #2657

Open timdhaeyer opened 1 week ago

timdhaeyer commented 1 week ago

Check for previous/existing GitHub issues

Description

I'm rewriting some of my bicep code to use AVM as much as possible. For my service bus namespace I'm setting a few rules via the default module 'Microsoft.ServiceBus/namespaces/topics/subscriptions/rules@2022-10-01-preview' I can't find this in the service-bus/namespace module in AVM. Is there a plan to add this?

AlexanderSehr commented 1 week ago

Hey @timdhaeyer, please excuse the late reply. Something must have gone wrong with the automatic-assignment of the issue. I just assigned the owner to triage the issue. From where I'm standing, nothing speaks against adding them. If there is already a solid 'plan' is a different story. That depends on @ChrisSidebotham's capacity. But if you want, I'm sure he wouldn't say no to a contribution either 😄

ChrisSidebotham commented 3 days ago

Hey @timdhaeyer - If you have or can contribute to this please do so. Otherwise I will add this to the VNEXT version of the module which will be published before the end of Calendar Q3

timdhaeyer commented 14 hours ago

@ChrisSidebotham Thanks for the reply. Not sure if I can contribute. Would be the first time for me. :-) I'll give it a go if I have some time in the coming weeks. I guess all the "rules" are clearly stated in the readme pages?

AlexanderSehr commented 13 hours ago

@ChrisSidebotham Thanks for the reply. Not sure if I can contribute. Would be the first time for me. :-) I'll give it a go if I have some time in the coming weeks. I guess all the "rules" are clearly stated in the readme pages?

'Clearly' is a strong term 😄 But we did create a contribution guide for this repository here. There are a couple 'Aha' moments when you start for the first time, but once you're set, you're set and won't have the same ramp up a second time. Also, (constructive) feedback is very much welcome 😉