Azure / bicep-registry-modules

Bicep registry modules
MIT License
460 stars 305 forks source link

[AVM Module Issue]: Make privateDnsZoneConfigs names configurable #2717

Closed cecheta closed 1 month ago

cecheta commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/network/private-endpoint

(Optional) Module Version

0.4.3

Description

As part of https://github.com/Azure/Azure-Verified-Modules/issues/1150, the private DNS zone config names require a specific name, different to the one supplied by the module, otherwise AI studio does not work correctly. The names should be configurable.

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 1 month ago

@cecheta, thanks for submitting this issue for the avm/res/network/private-endpoint module!

[!IMPORTANT] A member of the @Azure/avm-res-network-privateendpoint-module-owners-bicep or @Azure/avm-res-network-privateendpoint-module-contributors-bicep team will review it soon!

cecheta commented 1 month ago

Attempted to implement this in #2718 , keeping it backwards-compatible

microsoft-github-policy-service[bot] commented 1 month ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
segraef commented 1 month ago

Will be closed by #2718.