search

Azure / bicep-registry-modules

Bicep registry modules
MIT License
460 stars 305 forks source link

[AVM Module Issue]: `avm/res/databricks/workspace` Firewall support for workspace storage account #2753

Closed donheerschap closed 1 month ago

donheerschap commented 1 month ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/databricks/workspace

(Optional) Module Version

No response

Description

When having Databricks in an isolated workload where policies disable public access to resources it will break databricks because the workspace storage account is created default with public access.

According to these docs, firewall support & serverless private link, this is possible in the 2024-05-01 API with defaultStorageFirewall: 'Enabled'

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 1 month ago

@donheerschap, thanks for submitting this issue for the avm/res/databricks/workspace module!

[!IMPORTANT] A member of the @Azure/avm-res-databricks-workspace-module-owners-bicep or @Azure/avm-res-databricks-workspace-module-contributors-bicep team will review it soon!

donheerschap commented 1 month ago

@clintgrove I believe I already have a working example, I can fit the required properties and resources this weekend. I suggest the private endpoints for the workspace storage account are created from this module aswell.

clintgrove commented 1 month ago

Can I assume that you are going offer your idea up and raise a PR or would you like us to investigate to see if this is something we should add if needed?

donheerschap commented 1 month ago

@clintgrove I will raise a pr.