Azure / bicep-registry-modules

Bicep registry modules
MIT License
499 stars 347 forks source link

[AVM Module Issue]: Log Analytics Workspace option only works globally #3051

Closed Gossef closed 1 month ago

Gossef commented 2 months ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/operational-insights/workspace

(Optional) Module Version

0.4.0

Description

In order to use the Log Analytics Workspace itself for its own diagnostic settings, you can use this parameter: useDeployedWorkspaceForDiagnosticSettings

However that sets all diagnostic settings to point to this workspace. In our scenario we write all logs to a storage account and only a small selection (for example metrics) to the Log Analytics Workspace. This is now not possible, since without this setting we cannot reference the workspace itself and with the setting everything goes to the Workspace (as well as the storage account)

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 2 months ago

@Gossef, thanks for submitting this issue for the avm/res/operational-insights/workspace module!

[!IMPORTANT] A member of the @Azure/avm-res-operationalinsights-workspace-module-owners-bicep or @Azure/avm-res-operationalinsights-workspace-module-contributors-bicep team will review it soon!

microsoft-github-policy-service[bot] commented 2 months ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
krbar commented 2 months ago

@Gossef thanks for reporting this. I will discuss it with the team and come up with a fix