Azure / bicep-registry-modules

Bicep registry modules
MIT License
465 stars 308 forks source link

[AVM Module Issue]: DevTestLab missing parameter #3056

Closed HexagonSam closed 2 weeks ago

HexagonSam commented 3 weeks ago

Check for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/dev-test-lab/lab

(Optional) Module Version

No response

Description

The DevTestLab lab main bicep does not have a parameter for artifact repo token:

module lab_artifactSources 'artifactsource/main.bicep' = [
  for (artifactSource, index) in artifactsources: {
    name: '${uniqueString(deployment().name, location)}-Lab-ArtifactSources-${index}'
    params: {
      labName: lab.name
      name: artifactSource.name
      tags: artifactSource.?tags ?? tags
      displayName: contains(artifactSource, 'displayName') ? artifactSource.displayName : artifactSource.name
      branchRef: contains(artifactSource, 'branchRef') ? artifactSource.branchRef : ''
      folderPath: contains(artifactSource, 'folderPath') ? artifactSource.folderPath : ''
      armTemplateFolderPath: contains(artifactSource, 'armTemplateFolderPath')
        ? artifactSource.armTemplateFolderPath
        : ''
      sourceType: contains(artifactSource, 'sourceType') ? artifactSource.sourceType : ''
      status: contains(artifactSource, 'status') ? artifactSource.status : 'Enabled'
      uri: artifactSource.uri
    }
  }
]

The artifactsource module it references does contain this parameter available:

@sys.description('Optional. The security token to authenticate to the artifact source.')
@secure()
param securityToken string = ''

Without being able to specify this parameter in the main lab, we can't setup private repos.

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 3 weeks ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 3 weeks ago

@HexagonSam, thanks for submitting this issue for the avm/res/dev-test-lab/lab module!

[!IMPORTANT] A member of the @Azure/avm-res-devtestlab-lab-module-owners-bicep or @Azure/avm-res-devtestlab-lab-module-contributors-bicep team will review it soon!

ahmadabdalla commented 3 weeks ago

@HexagonSam thank you for raising the issue. We will look into this.

microsoft-github-policy-service[bot] commented 3 weeks ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!