search

Azure / bicep-registry-modules

Bicep registry modules
MIT License
499 stars 347 forks source link

[AVM Module Issue]: DCR 'kind' should allow being undefined to support both Windows and Linux. #3071

Closed jagiraud closed 1 month ago

jagiraud commented 2 months ago

Check for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/insights/data-collection-rule

(Optional) Module Version

0.2.0

Description

Property Kind is optional but defined with default value Linux in the template. This property should be optional without a default value to support xPlat (all) scenarios.

image

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 2 months ago

@jagiraud, thanks for submitting this issue for the avm/res/insights/data-collection-rule module!

[!IMPORTANT] A member of the @Azure/avm-res-insights-datacollectionrule-module-owners-bicep or @Azure/avm-res-insights-datacollectionrule-module-contributors-bicep team will review it soon!

krbar commented 2 months ago

@jagiraud thanks for reporting, I will take care of it

krbar commented 1 month ago

@jagiraud It turns out to be more complicated because the Resource provider does not accept the value kind: null or kind: '', but expects the "kind" to not be present in the module at all when creating a cross-platform Data Collection Rule. I've created a ticket with the product group. I will keep the issue updated

krbar commented 1 month ago

@jagiraud The update is implemented and the corresponding PR (see above) in review. Once the module is published, you can deploy a cross-platform DCR using the param dataCollectionRuleProperties.kind: 'All'