Azure / bicep-registry-modules

Bicep registry modules
MIT License
465 stars 308 forks source link

[AVM Module Issue]: Container Registry cache rules credentialSetResourceId is required #3072

Open iliyansi opened 3 weeks ago

iliyansi commented 3 weeks ago

Check for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/container-registry/registry

(Optional) Module Version

No response

Description

When i want to deploy cache rule to container registry property credentialSetResourceId is a required property but on oficial bicep API this one is not a required property. It should be required only for docker cached rules. all the other types support anonymous pull.

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 3 weeks ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 3 weeks ago

@iliyansi, thanks for submitting this issue for the avm/res/container-registry/registry module!

[!IMPORTANT] A member of the @Azure/avm-res-containerregistry-registry-module-owners-bicep or @Azure/avm-res-containerregistry-registry-module-contributors-bicep team will review it soon!

JPEasier commented 3 weeks ago

Hi @iliyansi

I will create a fix as soon as posible, thanks for pointing out!

iliyansi commented 3 weeks ago

Hi @JPEasier thanks.