Azure / bicep-registry-modules

Bicep registry modules
MIT License
472 stars 327 forks source link

[AVM Module Issue]: Network Watcher - Flow logs don't pass the tags #3319

Open awood86 opened 2 weeks ago

awood86 commented 2 weeks ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/network/network-watcher

(Optional) Module Version

0.3.0

Description

I'm working on a project where all resources require a tag, but it looks like the flow logs within the Network Watcher AVM aren't passed, are you able to add that in at all?

Thanks

module networkWatcher_flowLogs 'flow-log/main.bicep' = [
  for (flowLog, index) in flowLogs: {
    name: '${uniqueString(deployment().name, location)}-NW-FlowLog-${index}'
    params: {
      enabled: contains(flowLog, 'enabled') ? flowLog.enabled : true
      formatVersion: contains(flowLog, 'formatVersion') ? flowLog.formatVersion : 2
      location: contains(flowLog, 'location') ? flowLog.location : location
      name: contains(flowLog, 'name')
        ? flowLog.name
        : '${last(split(flowLog.targetResourceId, '/'))}-${split(flowLog.targetResourceId, '/')[4]}-flowlog'
      networkWatcherName: networkWatcher.name
      retentionInDays: contains(flowLog, 'retentionInDays') ? flowLog.retentionInDays : 365
      storageId: flowLog.storageId
      targetResourceId: flowLog.targetResourceId
      trafficAnalyticsInterval: contains(flowLog, 'trafficAnalyticsInterval') ? flowLog.trafficAnalyticsInterval : 60
      workspaceResourceId: contains(flowLog, 'workspaceResourceId') ? flowLog.workspaceResourceId : ''
    }
  }
]

(Optional) Correlation Id

No response

microsoft-github-policy-service[bot] commented 2 weeks ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 2 weeks ago

@thatbluesky, thanks for submitting this issue for the avm/res/network/network-watcher module!

[!IMPORTANT] A member of the @Azure/avm-res-network-networkwatcher-module-owners-bicep or @Azure/avm-res-network-networkwatcher-module-contributors-bicep team will review it soon!

microsoft-github-policy-service[bot] commented 1 week ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 1 week ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
microsoft-github-policy-service[bot] commented 1 week ago

[!CAUTION] This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days.

[!TIP]

  • To avoid this rule being (re)triggered, the "Needs: Triage :mag:" and "Status: Response Overdue :triangular_flag_on_post:" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention :bangbang:" label once the issue has been responded to.