Azure / bicep-registry-modules

Bicep registry modules
MIT License
469 stars 319 forks source link

[AVM Module Issue]: Confusing property alignment for targetDnsServer in DNS forwarding Ruleset #3347

Open ShahradMaersk opened 6 hours ago

ShahradMaersk commented 6 hours ago

Check for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/network/dns-forwarding-ruleset

(Optional) Module Version

0.4.0

Description

https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/network/dns-forwarding-ruleset#parameter-forwardingrulestargetdnsserversport

Attempting to create a Rule set and am experiencing a weird issue, not sure how to mitigate. Using this module to deploy with JSON parameters being parsed through - i cannot define the port as a string because it is only a number entry. Port 53 on targetDNSserver block can only be an integer, yet this module wants it as string when the original API module calls for it as integer, not sure why here.

Error message:

InvalidTemplate - Deployment template validation failed: 'The provided value for the template parameter 'forwardingRules[0].targetDnsServers[0].port' is not valid. Expected a value of type 'String, Uri', but received a value of type 'Integer'. Please see https://aka.ms/arm-create-parameter-file for usage details.'.

Please see here for the bicep api version of this, as CARML also used this i believe?

https://learn.microsoft.com/en-us/azure/templates/microsoft.network/dnsforwardingrulesets/forwardingrules?pivots=deployment-language-bicep#targetdnsserver

(Optional) Correlation Id

No response

avm-team-linter[bot] commented 5 hours ago

@ShahradMaersk, thanks for submitting this issue for the avm/res/network/dns-forwarding-ruleset module!

[!IMPORTANT] A member of the @Azure/avm-res-network-dnsforwardingruleset-module-owners-bicep or @Azure/avm-res-network-dnsforwardingruleset-module-contributors-bicep team will review it soon!

microsoft-github-policy-service[bot] commented 5 hours ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.