Azure / bicep-registry-modules

Bicep registry modules
MIT License
513 stars 362 forks source link

feat: Add solutionPlanType to the `avm/res/operations-management/solution` module #3718

Closed krbar closed 2 weeks ago

krbar commented 2 weeks ago

Description

Adding an exportable solutionPlanType type definition to the avm/res/operations-management/solution module.

Pipeline Reference

Pipeline
avm.res.operations-management.solution

Type of Change

Checklist

microsoft-github-policy-service[bot] commented 2 weeks ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

microsoft-github-policy-service[bot] commented 2 weeks ago

[!IMPORTANT] If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

ReneHezser commented 2 weeks ago

Hi @krbar. The type is not used in this module. I am wondering why the type is added here and who is/will use it. Update: I found where it will be used. In this module, however, it is not used. Instead, the "old" parameters still exist. You don't want to create a new parameter with the type here as well?