Azure / bicep-registry-modules

Bicep registry modules
MIT License
515 stars 363 forks source link

[AVM Module Issue]: Enable serverless capability as a general setup #3753

Open dmusic opened 2 weeks ago

dmusic commented 2 weeks ago

Check for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/document-db/database-account

(Optional) Module Version

0.8.1

Description

In current version of the CosmosDB AVM module, users of the module need to create a "dummy" database for NoSQL, Gremlin, MongoDB and Table APIs to be able to enable serverless capacity mode.

The affected code in module is this:

{
    databaseAccountOfferType: databaseAccountOfferType
    backupPolicy: backupPolicy
    minimalTlsVersion: minimumTlsVersion
  },
  ((!empty(sqlDatabases) || !empty(mongodbDatabases) || !empty(gremlinDatabases) || !empty(tables))
    ? {
       ...
       **capabilities: capabilities**
       ...
   }

As this is general configuration, this should be moved in the first part of that union, including databaseAccountOfferType, backupPolicy and TLS config. This would improve the product and remove demand to create "dummy" databases to set correct serverless capacity mode.

This should be a quick fix and would benefit the product.

(Optional) Correlation Id

https://github.com/Azure/bicep-registry-modules/issues/2189

microsoft-github-policy-service[bot] commented 2 weeks ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

avm-team-linter[bot] commented 2 weeks ago

@dmusic, thanks for submitting this issue for the avm/res/document-db/database-account module!

[!IMPORTANT] A member of the @Azure/avm-res-documentdb-databaseaccount-module-owners-bicep or @Azure/avm-res-documentdb-databaseaccount-module-contributors-bicep team will review it soon!

microsoft-github-policy-service[bot] commented 1 week ago

[!WARNING] Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

[!TIP]

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage :mag:" label must be removed as part of the triage process (when the issue is first responded to)!
seesharprun commented 5 days ago

@bryansan-msft, there seems to be multiple issues where users would like to see features like publicNetworkAccess and capabilities outside of the conditional so they can use them even if they don't define sub-resources.

This would require a significant rework of the document-db module to make happen. Is this something you want to discuss in a new issue?