search

Azure / bicep-types-az

Bicep type definitions for ARM resources
MIT License
80 stars 26 forks source link

Complete Mode deletes Logic App workflows definitions #1951

Open x2xamin opened 7 months ago

x2xamin commented 7 months ago

Bicep version 0.23.1

Describe the bug Resource deployment using --mode Complete deletes workflow json data including definition of Azure Logic App, even if Logic App is part of bicep template. Since we cannot make json workflow part of bicep template, please let workflow persists using --mode Complete. To Reproduce Redeploy Azure Logic App with bicep --mode Complete, all worflow data will be deleted and reverts to default blank workflow

Additional context It is also mentioned in official document that Complete mode will delete workflow of Logic App, which it should not https://learn.microsoft.com/en-us/azure/azure-resource-manager/templates/deployment-complete-mode-deletion#microsoftlogic

alex-frankel commented 7 months ago

Complete Mode vs Incremental Mode is not relevant here as that only affects how the deployments should handle the presence/absence of an entire resource declaration. We are blind to the actual property changes. If you would like the Logic App RP to change their behavior on an update, that ask will need to be routed to that team. I would recommend opening a support case for this. Out of curiosity, why can't the logic app workflow be included in an update?

As a side note, we no longer recommend using "Complete" mode. We'd suggest using Deployment Stacks instead.

microsoft-github-policy-service[bot] commented 4 months ago

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/azure-logicapps-team. Please see https://aka.ms/biceptypesinfo for troubleshooting help.