Azure / bicep-types-az

Bicep type definitions for ARM resources
MIT License
83 stars 26 forks source link

Azure Container Apps - KEDA scale (managed identity) #2238

Open verschaevesiebe opened 1 month ago

verschaevesiebe commented 1 month ago

Hi All,

Referencing to the updated microsoft Azure docs. [https://learn.microsoft.com/en-us/azure/container-apps/scale-app?pivots=azure-cli#using-managed-identity-1](Microsoft Azure Scaling Container Apps).

There's an additional property / parameter the cli expects which is "scale-rule-identity" image

This isn't available yet in the 2024-03 API version of bicep. Can someone have a look and provide an update and release a new version ?

Many thanks.

anthony-c-martin commented 1 month ago

@jcjiang is this --scale-rule-identity param in the docs accurate? I can't find any reference to it in the Azure CLI code, or via running --help. I see it was originally added to the docs with https://github.com/MicrosoftDocs/azure-docs-pr/pull/277206.

anthonychu commented 1 month ago

It's a preview feature that's only available in 2024-02-02-preview (see identity under scale rules).

In the CLI, preview features require an extension (az extension add -n containerapp --allow-preview true). source

@anthony-c-martin Somewhat related, do you know how to get 2024-02-02-preview and 2024-03-01 to appear in the Bicep reference?

verschaevesiebe commented 1 month ago

We've used the 2024-02-02-preview and everything seems to work, thanks ! We did notice nothing is visible related to the attached identity in the Azure Portal though but i would assume that will be added later by the portal team.

I've been doing bicep since it's private preview releases but i've always struggled to what the API versions actually mean and entail. Is there a page where there's more information to what each field does per API version and what those API Versions actually mean ? A lot of people on my team blindly bump the version (we never had issues) but something tells me with this kind of thing that might be a bad thing now 🗡️ .

Any reference to a specific documentation page for api versions would be most welcome.

Looking forward to this.

anthony-c-martin commented 1 month ago

@verschaevesiebe a somewhat related comment on this here: https://github.com/Azure/bicep/issues/1002#issuecomment-733850619

anthony-c-martin commented 1 month ago

@anthonychu the Bicep reference docs are generated from Bicep types (this repo). I can see we've got type information available for these two API versions, so I assume either something has gone wrong with the docs generation process, or it has not run recently.

Here's where I see them: https://github.com/Azure/bicep-types-az/blob/main/generated/app/microsoft.app/2024-03-01/types.md https://github.com/Azure/bicep-types-az/blob/main/generated/containerservice/microsoft.containerservice/2024-04-02-preview/types.md

@tfitzmac/@mumian could you take a look to see if anything needs to happen to re-generate the Bicep reference docs?