search

Azure / bicep

Bicep is a declarative language for describing and deploying Azure resources
MIT License
3.18k stars 732 forks source link

"Default Bicep Configuration" snippet shows up in settings.json autocomplete #10739

Open digitarald opened 1 year ago

digitarald commented 1 year ago

Type: Bug

I see noisy Biceps entries when filling in values in VS Code's settings.json, which doesn't make sense.

image

Extension version: 0.17.1 VS Code version: Code - Insiders 1.79.0-insider (f1258a5fbed44b8f84a097c73c1799c13c5c3646, 2023-05-17T05:27:27.525Z) OS version: Darwin x64 22.4.0 Modes: Remote OS version: Linux x64 5.4.0-1106-azure

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|2, 3, 3| |Memory (System)|64.00GB (0.11GB free)| |Process Argv|--enable-proposed-api digitarald.chat-ai-plugins --log trace --crash-reporter-id 4cf0a6f0-aaf8-4da3-9b2b-81f6c639c12b| |Screen Reader|no| |VM|0%| |Item|Value| |---|---| |Remote|Codespaces| |OS|Linux x64 5.4.0-1106-azure| |CPUs|Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz (8 x 2793)| |Memory (System)|15.63GB (11.88GB free)| |VM|0%|
StephenWeatherford commented 1 year ago

https://github.com/microsoft/vscode/issues/185710

StephenWeatherford commented 1 year ago

There's nothing I can do unless vscode fixes https://github.com/microsoft/vscode/issues/185710 (and then I need to make a change to the extension). How do we handle this issue?

StephenWeatherford commented 1 year ago

Actually, I think it makes sense to remove this snippet altogether because:

1) we already have this command: image 2) the snippet doesn't contain much: image 3) we already have Intellisense for the file *if the user first saves it as "bicepconfig.json" before trying to edit image And with https://github.com/Azure/bicep/issues/11092: image

4) currently we only show the snippet if you set a new file to JSONC, and not JSON (because bicepconfig.json is set to be JSONC and it helps reduce the places where we incorrectly show the file, but it means that in the common scenario of creating a new file then setting it to JSON, you will already not see the snippet).