search

Azure / bicep

Bicep is a declarative language for describing and deploying Azure resources
MIT License
3.21k stars 745 forks source link

Support token auth in ACR premium #4947

Open majastrz opened 2 years ago

majastrz commented 2 years ago

ACR premium supports authenticating via tokens: https://docs.microsoft.com/en-us/azure/container-registry/container-registry-repository-scoped-permissions. We should support that for ACR requests.

majastrz commented 2 years ago

Related to #4884.

alex-frankel commented 2 years ago

Will this also allow for querying a single ACR instance across tenants? So I create ACR in tenant A, but want to reference in a deployment to tenant B.

majastrz commented 2 years ago

Yes, that should work. These tokens are really using Basic Authentication, so they wouldn't be tied to any AAD tenant.

ggirard07 commented 2 years ago

Are there any plan to support generating the actual token credential from bicep too (password1 and password2)? Looks like currently the only available solution is through the CLI.

In my case, I would like to then inject it as a keyvault secret or reuse it to configure other resources.

PixelRobots commented 1 year ago

hey @alex-frankel any update one this?

cedricbraekevelt commented 11 months ago

@alex-frankel I'm also looking forward to this feature, to use scope maps. Since template spec doesn't work between different tenants...

quality-leftovers commented 10 months ago

+1. Bicep module restore not working for ACR in another tenant is a major hurdle if you have a dev and prod tenant (private registries for bicep are kinda useless without this IMHO)

PixelRobots commented 6 months ago

Hey @alex-frankel any update on token support?

alex-frankel commented 6 months ago

No major updates, but @sydkar / @majastrz are working out a plan to update the ORAS .NET client such that we can take a dependency on it instead of relying on the ACR SDK which binds us to ACR. We might know more in about a month.

PixelRobots commented 2 months ago

Hey, Just wondering if there is any update on this?

quality-leftovers commented 1 month ago

Any update?