search

Azure / cadl-ranch

Cadl Scenarios for client generations
https://azure.github.io/cadl-ranch/
MIT License
8 stars 32 forks source link

[cadl-ranch-*] Backport the server testing changes from typespec repository to cadl-ranch repository #741

Closed sarangan12 closed 1 month ago

sarangan12 commented 1 month ago

As part of cadl-ranch migration, several packages have been migrated from cadl-ranch repository to typespec repository. Now, the changes made to the typespec repository has to be backported to the cadl-ranch repository. This PR accomplishes that.

This PR consists of the following changes:

  1. Changes to the cadl-ranch-api & cadl-ranch packages have been migrated from the corresponding packages in the typespec repository. Except for 3 design changes, there is no bigger changes. These 3 changes are indicated in the PR Comments.
  2. Changes to the cadl-ranch-specs repository have been migrated from the corresponding package in the typespec repository. In addition to the endpoints in the typespec repository, the following folders have been migrated to new model:
    • client folder
    • azure folder
    • resiliency folder
    • payload/pageable folder

This change is done for 2 reasons. One, We do not want anyone to add new features in these folders using the old model. Second, I am planning to port these folders to the new package azure-http-specs for which I will create the PR shortly after this is merged.

I have already executed e2e scenarios and all validations are successful.

Note I have not made any major/minor version bumps for any of the 3 packages involved in this PR

Please review and approve the PR. Thanks

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 1494b41410a1cd1d3d884532c4c4c7be2571a126

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ----------------------------- | ----- | | @azure-tools/cadl-ranch-specs | Patch | | @azure-tools/cadl-ranch-api | Patch | | @azure-tools/cadl-ranch | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

timotheeguerin commented 1 month ago

LGTM for azure/resource-manager.

So in the future, we should only update 4 azure scenarios(azure/client/resiliency/pageable) in this repo, and for others, we should be writing in microsoft/typespec?

for a short period of time if you need to update teh typespec scenarios you should update it in both place.

For azure we are also moving them to the typespec-azure repo so you will need to update it there when that is done too.

When that is done we'll try to quickly rollout on having everyone use the new typespec and typespec-azure version instead so we can stop maintaining this repo