Azure / caf-terraform-landingzones-accelerator

Starter project for Applications (level 4) Cloud Adoption Framework for Azure landing zones on Terraform
MIT License
205 stars 232 forks source link

Deployment of sandpit level4 fails #83

Open pieterGitHub opened 3 years ago

pieterGitHub commented 3 years ago

Describe the bug The level4 deployment does not complete.

bash script stop and prompts for a value for _var.aks_clusterkey : _var.aks_clusterkey Enter a value:

Branch: starter

To Reproduce Run bash script as per "/tf/caf/configuration/sandpit/level4/argocd/README.md" - Lines 31 to 36 (as below)

rover -lz /tf/caf/landingzones/caf_solution/add-ons/aks_applications/ \
  -tfstate ${application}1.tfstate \
  -var-folder /tf/caf/configuration/${environment}/level4/${application} \
  -var tags={application=\"${application}\"} \
  -level level4 \
  -a plan

Error: script does not complete and prompts user to enter value for: _var.aks_cluster_key_

Expected behavior bash script should not prompt for any parameters

Screenshots

Environment (please complete the following information):

Additional context

kgibson-insight commented 3 years ago

were you able to get level1 deployed successfully?

daumie commented 3 years ago

@kgibson-insight I was able to. Which blockers are you facing?

kgibson-insight commented 3 years ago

Logged an issue here

https://github.com/Azure/caf-terraform-landingzones-starter/issues/91

henrydobson commented 3 years ago

Did you find the resolution to this issue as I also have encountered the same thing at level4

arnaudlh commented 3 years ago

the readme prompts not only the rover command but also exporting the keys:

application="argocd"
# Landingzone key hosting the AKS cluster
landingzone_key="cluster_aks"
# Key of the cluster to deploy the application
cluster_key="cluster_re1"

rover -lz /tf/caf/landingzones/caf_solution/add-ons/aks_applications/ \
  -tfstate ${application}1.tfstate \
  -var-folder /tf/caf/reference_implementations/azure_kubernetes_services/applications/${application} \
  -var tags={application=\"${application}\"} \
  -level level4 \
  -a [plan|apply|destroy]

As per: https://github.com/Azure/caf-terraform-landingzones-starter/tree/starter/configuration/sandpit/level4/argocd