[Calling][Bugfix] Skip setup screen logic should be based on redux state - Githubissues

Azure / communication-ui-library-android

Azure Communication UI Mobile Library for Android

https://learn.microsoft.com/en-us/azure/communication-services/concepts/ui-library/ui-library-overview?pivots=platform-web

MIT License

24 stars 29 forks source link

[Calling][Bugfix] Skip setup screen logic should be based on redux state #944

Closed pavelprystinka closed 8 months ago

pavelprystinka commented 8 months ago

Purpose

Skip setup screen logic should be based on redux state

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Pull Request Checklist

[ ] Public API changes
[ ] Verified for cross-platform
[ ] Synced with iOS, Web team
[ ] Internal review completed
[ ] UI Changes
- [ ] Screen captures included
- [ ] Tested for Light/Dark mode
- [ ] Tested for screen rotation
- [ ] Tested on Tablet and small screen device (5")
- [ ] Include localization changes
[ ] Tests
- [ ] Memory leak analysis performed
- [ ] Tested on API 21, 26 and latest
- [ ] Tested for background mode
- [ ] Unit Tests Included
- [ ] UI Automated Tests Included

How to Test

Open...
Click on...

What to Check

Verify that the following are valid

...

Other Information

ahammer commented 8 months ago

Does this need to be 62 files changed, +916/-1003 lines?