search

Azure / container-apps-deploy-action

GitHub Action for building and deploying Azure Container Apps
MIT License
51 stars 30 forks source link

Updated docker/login-action@v2.0.0 to v2.2.0 #47

Closed afefer closed 1 year ago

afefer commented 1 year ago

Fixes following warning thrown when using this action:

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/Show more

cormacpayne commented 1 year ago

Hmm looks like this may be the first time our CI/CD was run against a fork of this repository and it seems to be trying to pick up repository secrets/variables from the fork rather than this repository 🤔 I'll investigate this a bit and see what's going on.

cormacpayne commented 1 year ago

@afefer Hey Alex, so it doesn't appear that there's a simple way to get CI/CD to work for external forks 😞 I migrated your changes into a new branch hosted within this repository, found here: https://github.com/Azure/container-apps-deploy-action/pull/48

Hopefully this is OK for you in the interim! Thanks again for the changes you've proposed!

afefer commented 1 year ago

Hey @cormacpayne, no problem at all! Thanks for the quick turnaround :)