search

Azure / container-apps-deploy-action

GitHub Action for building and deploying Azure Container Apps
MIT License
52 stars 29 forks source link

feat: Support build arguments for docker build #64

Closed FabianMeul closed 7 months ago

FabianMeul commented 1 year ago

Support for --build-arg during docker build. Introduces the dockerfileBuildArguments parameter that contains a space-separated list of "key=value".

Closes #8 and #51.

FabianMeul commented 1 year ago

@FabianMeul please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

FabianMeul commented 1 year ago

@cormacpayne Any feedback regarding this one? :-)

FabianMeul commented 1 year ago

Thx for looking into this and the feedback. Agreed on making this more specific.

Changes are coming up!

FabianMeul commented 1 year ago

Hey @cormacpayne

I've moved on to another solution, but I would gladly return to use this GA once this gets merged. ;-)

peter064226 commented 1 year ago

i really need this feature

FabianMeul commented 11 months ago

@cormacpayne Any chance of getting this approved?...