Azure / container-apps-deploy-action

GitHub Action for building and deploying Azure Container Apps
MIT License
50 stars 30 forks source link

Hide output from 'az containerapp' commands #65

Closed cormacpayne closed 11 months ago

cormacpayne commented 11 months ago

This PR addresses the following:

bcspragu commented 11 months ago

Hello! I think this PR breaks some deploys. There seems to be a line --output that should be --output none:

https://github.com/Azure/container-apps-deploy-action/blame/ccd0cf4128b53751252c85270a8922e5c04a0c78/action.yml#L347

Example error: https://github.com/RMI-PACTA/app/actions/runs/6476788688/job/17586033990

Run az containerapp show \
  az containerapp show \
    -g rmi-pacta-dev \
    -n pactasrv-dev \
    --output && CA_GH_ACTION_RESOURCE_EXISTS=true || CA_GH_ACTION_RESOURCE_EXISTS=false
  echo "CA_GH_ACTION_RESOURCE_EXISTS=${CA_GH_ACTION_RESOURCE_EXISTS}" >> $GITHUB_ENV
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    AZURE_HTTP_USER_AGENT: 
    AZUREPS_HOST_ENVIRONMENT: 
    CA_GH_ACTION_IMAGE_TO_DEPLOY: rmipacta.azurecr.io/pacta:dev
    CA_GH_ACTION_RESOURCE_GROUP: rmi-pacta-dev
    CA_GH_ACTION_CONTAINER_APP_LOCATION_ARG: --location centalus

ERROR: argument --output/-o: expected one argument
daniv-msft commented 11 months ago

Thank you very much @bcspragu ! We're looking into this and will get back to you

daniv-msft commented 11 months ago

@bcspragu We've merged the PR fixing this: https://github.com/Azure/container-apps-deploy-action/pull/66 We'll release it in a few minutes. Thanks again and sorry for the issue.

bcspragu commented 11 months ago

No worries @daniv-msft, and thanks for the quick turnaround!

daniv-msft commented 11 months ago

Thanks! I confirm the change was released. Kudos to @cormacpayne

cormacpayne commented 11 months ago

Thank you for the catch @bcspragu :shipit: